mlaga97
/
PySimpleGUI
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #3184 from PySimpleGUI/Dev-latest 

Key error formatting. Raise by default
This commit is contained in:
PySimpleGUI 2020-07-25 14:26:44 -04:00 committed by GitHub
parent b30e31d91f 4d67b08c2e
commit 8177887495
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 18 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
PySimpleGUI.py
View File

@ -1,5 +1,5 @@
#!/usr/bin/python3 #!/usr/bin/python3
version = __version__ = "4.26.0.9 Unreleased\nNew Sponsor button, highly experimental read_all_windows(), search option for theme previewer, theme button in main, progress bar color can use new 'on' format, combined ProgressBar.update_bar with ProgressBar.update so now only update is needed, theme previewer restore previous theme, raise KeyError when find_element or window[] hits a bad key (unless find_element has silent error set), better traceback shown on key errors, fix for get item" version = __version__ = "4.26.0.10 Unreleased\nNew Sponsor button, highly experimental read_all_windows(), search option for theme previewer, theme button in main, progress bar color can use new 'on' format, combined ProgressBar.update_bar with ProgressBar.update so now only update is needed, theme previewer restore previous theme, raise KeyError when find_element or window[] hits a bad key (unless find_element has silent error set), better traceback shown on key errors, fix for get item, formatting of error location information. raise key error by default"
port = 'PySimpleGUI' port = 'PySimpleGUI'
@ -407,7 +407,7 @@ MENU_KEY_SEPARATOR = '::'
ENABLE_TK_WINDOWS = False ENABLE_TK_WINDOWS = False
SUPPRESS_ERROR_POPUPS = False SUPPRESS_ERROR_POPUPS = False
SUPPRESS_RAISE_KEY_ERRORS = True SUPPRESS_RAISE_KEY_ERRORS = False
ENABLE_TREEVIEW_869_PATCH = True ENABLE_TREEVIEW_869_PATCH = True
OLD_TABLE_TREE_SELECTED_ROW_COLORS = ('#FFFFFF', '#4A6984') OLD_TABLE_TREE_SELECTED_ROW_COLORS = ('#FFFFFF', '#4A6984')
@ -7630,31 +7630,38 @@ class Window:
""" """
try: try:
element = self.AllKeysDict[key] element = self.AllKeysDict[key]
key_error = False
except KeyError: except KeyError:
element = None
if not silent_on_error: if not silent_on_error:
warnings.warn( print('** Error looking up your element using the key: ', key)
"*** WARNING = FindElement did not find the key. Please check your key's spelling if it's a string. key = {} ***".format(key), UserWarning)
trace_details = traceback.format_stack() trace_details = traceback.format_stack()
error_message = '' error_message = ''
for line in trace_details: for line in trace_details:
if key in line: if str(key).replace(' ','') in str(line).replace(' ', ''):
error_message = line error_message = line
break break
error_message = '\n'.join(error_message.split(',')) if error_message != '':
error_parts = error_message.split(', ')
if len(error_parts) < 4:
error_message = error_parts[0]+'\n'+error_parts[1]+ '\n' + ''.join(error_parts[2:])
if not SUPPRESS_ERROR_POPUPS: if not SUPPRESS_ERROR_POPUPS:
popup_error('Key error in locating your element', popup_error('Key error in locating your element',
'Bad key = {}\n'.format(key), 'Bad key = {}\n'.format(key),
error_message, error_message,
line_width=100, line_width=100,
keep_on_top=True, image=_random_error_icon()) keep_on_top=True, image=_random_error_icon())
if not SUPPRESS_RAISE_KEY_ERRORS: # if not SUPPRESS_RAISE_KEY_ERRORS:
raise KeyError(key) # raise KeyError(key)
else: # else:
element = ErrorElement(key=key) element = ErrorElement(key=key)
key_error = True
else: else:
element = ErrorElement(key=key) element = ErrorElement(key=key)
return element return element
if key_error:
if not SUPPRESS_RAISE_KEY_ERRORS:
raise KeyError(key)
return element return element
Element = FindElement # Shortcut function Element = FindElement # Shortcut function